Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed group issue #1261

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: fixed group issue #1261

merged 1 commit into from
May 3, 2024

Conversation

mishramonalisha76
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

github-actions bot commented May 3, 2024

In the file ChatViewComponent.tsx:

  1. The variable ChatViewComponentCard is referenced in the JSX but not defined in the code. It needs to be imported from styled-components or defined within the file.
  2. The commented out code for <CreateGroupModal> should be removed to clean up the code.
  3. There is a commented out prop welcomeComponent in the <ChatView> component. It needs to be either removed or uncommented with valid code.
  4. There is an unused array chatFilterList. If it's not required, it should be removed to avoid clutter.
  5. The import for UserProfile is not used in the code and can be removed.
  6. In the import statement, '@pushprotocol/uiweb' seems like a fictional package name, which may lead to confusion or errors. It needs to be corrected to the actual package name if it's a mistake.
  7. Check the logic within chatProfileLeftHelperComponent and chatProfileRightHelperComponent to ensure they are functioning as intended.

In the file ChatViewList.tsx:

  1. There are syntax errors in the code:
    • Missing closing curly brace for if (!user) {.
    • Missing closing curly brace for the function transformSteamMessage.
    • Missing closing curly brace for the function transformGroupDetails.
    • Missing closing curly brace for the .map function of messages?.map((chat: IMessageIPFS, index: number).
    • The useEffect hook is missing a closing bracket after await getMessagesCall();.
    • The if conditions within useEffect hooks are not properly structured and might lead to unexpected behavior.
  2. The function pCAIP10ToWallet is referenced but not defined in the given code snippet, it should be imported or defined in the file.
  3. The usage of the styled-components in the component styling is correct.
  4. Make sure that the logic for handling chat messages and initializing state variables is correct and follows the intended behavior.

After addressing the above points, the code seems well-structured and functional. If all the above points are being considered or already addressed, the code review for these files is complete.

All looks good.

@mishramonalisha76 mishramonalisha76 merged commit 2f67e3c into main May 3, 2024
1 check passed
mishramonalisha76 added a commit that referenced this pull request May 3, 2024
* fix: published new version

* fix: fixed placement of chat (#1260)

* fix: fixed placement of chat

* fix: fixed group issue

* fix: fixed group issue (#1261)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants