-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scw support #1250
Add scw support #1250
Conversation
In the
In the
In the
In the
Based on the identified issues, the corrected changes should be made in the respective files. |
In the
After fixing the above issues: {
"name": "@pushprotocol/restapi",
"version": "0.0.1-alpha.89",
"type": "commonjs",
"publishConfig": {
"registry": "https://registry.npmjs.org/"
},
"peerDependencies": {
"ethers": "^5.0.0 || ^6.0.0"
},
"peerDependenciesMeta": {
"ethers": {
"optional": true
}
},
"dependencies": {
"@lit-protocol/lit-node-client": "^5.0.0",
"@metamask/eth-sig-util": "^5.0.2",
"buffer": "^6.0.3",
"crypto-js": "^4.1.1",
"immer": "^10.0.2",
"joi": "^17.9.2",
"livepeer": "^2.5.8",
"lru-cache": "^10.1.0",
"openpgp": "^5.5.0",
"shamir-secret-sharing": "^0.0.3",
"simple-peer": "^9.11.1",
"socket.io-client": "^4.7.2",
"video-stream-merger": "^4.0.1",
"vue": "^3.0.0"
},
"scripts": {
"test": "TS_NODE_PROJECT='./tsconfig.mocha.json' NODE_OPTIONS='--loader ts-node/esm' DOTENV_CONFIG_PATH='./tests/.env' mocha -r ts-node/register -r dotenv/config 'tests/**/*.test.ts' --timeout 1200000 --require tests/root.ts --serial"
},
"devDependencies": {
"@types/chai": "^4.3.4",
"@types/chai-as-promised": "^7.1.5",
"@types/crypto-js": "^4.1.1",
"@types/mocha": "^10.0.1",
"chai": "^4.3.7",
"chai-as-promised": "^7.1.1",
"envfile": "^7.1.0",
"mocha": "^10.2.0",
"mocha-typescript": "^1.1.17",
"ts-node": "^10.9.1",
"typescript": "^5.0.2"
}
} In the
In the
In the
In the
Overall, the code has several issues and missing implementations. It needs further development and corrections before it can be considered ready. |
In the
Therefore, the correct formatting of the package.json file should be: {
"name": "@pushprotocol/restapi",
"version": "0.0.1-alpha.89",
"type": "commonjs",
"publishConfig": {
"registry": "https://registry.npmjs.org/"
},
"peerDependencies": {
"ethers": "^5.0.0 || ^6.0.0"
},
"peerDependenciesMeta": {
"ethers": {
"optional": true
}
},
"dependencies": {
"@lit-protocol/lit-node-client": "^5.0.0",
"@metamask/eth-sig-util": "^5.0.2",
"buffer": "^6.0.3",
"crypto-js": "^4.1.1",
"immer": "^10.0.2",
"joi": "^17.9.2",
"livepeer": "^2.5.8",
"lru-cache": "^10.1.0",
"openpgp": "^5.5.0",
"shamir-secret-sharing": "^0.0.3",
"simple-peer": "^9.11.1",
"socket.io-client": "^4.7.2",
"video-stream-merger": "^4.0.1",
"viem": "^1.20.3"
},
"scripts": {
"test": "TS_NODE_PROJECT='./tsconfig.mocha.json' NODE_OPTIONS='--loader ts-node/esm' DOTENV_CONFIG_PATH='./tests/.env' mocha -r ts-node/register -r dotenv/config 'tests/**/*.test.ts' --timeout 1200000 --require tests/root.ts --serial"
},
"devDependencies": {
"@types/chai": "^4.3.4",
"@types/chai-as-promised": "^7.1.5",
"@types/crypto-js": "^4.1.1",
"@types/mocha": "^10.0.1",
"chai": "^4.3.7",
"chai-as-promised": "^7.1.1",
"envfile": "^7.1.0",
"mocha": "^10.2.0",
"mocha-typescript": "^1.1.17",
"ts-node": "^10.9.1",
"typescript": "^5.0.2"
}
} In the I would suggest making these corrections in the respective files. All looks good. |
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers