-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(uiweb): return response in createGroupModal #1198
Conversation
return group information when group is successfully created in uiweb createGroupModal
In the file
Overall, the code review has identified some syntax errors and missing elements that need to be addressed. All looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just change the base to alpha
File: packages/uiweb/src/lib/components/chat/CreateGroup/AddCriteria.tsx
File: packages/uiweb/src/lib/components/chat/CreateGroup/CreateGroupModal.tsx
Overall, there are multiple syntax errors, typos, and logic issues that need to be fixed in the code. All looks good. |
* feat(uiweb): return response in createGroupModal return group information when group is successfully created in uiweb createGroupModal * fix: fixed build issue --------- Co-authored-by: Siddesh Sankhya <[email protected]>
returns group information when group is successfully created in uiweb createGroupModal
Closes #1197