New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: z-index modal" #1153

Merged

mishramonalisha76 merged 1 commit into alpha from revert-1152-modal-z-index

Mar 6, 2024

Contributor

mishramonalisha76 commented Mar 6, 2024

Reverts #1152


          Revert "fix: z-index modal (#1152)"

1726d34

This reverts commit 4e40221.

mishramonalisha76 merged commit ad47344 into alpha

github-actions bot commented Mar 6, 2024

In the Modal component, the import statement for ModalBackgroundType and ModalPositionType is incorrect. It should be imported as follows:

import { MODAL_BACKGROUND_TYPE, MODAL_POSITION_TYPE } from '../../../types';

In the ModalHeader component, there is a typo in the prop fontWeight. It should be font-weight instead of fontWeight.
In the ModalHeader component, the Image component is not imported. It should be imported as follows:

import { Image } from '../../reusables';

The commented section in the ModalParent styled component should be enclosed in /* and */ for proper commenting as shown:

  /* @media ${device.mobileL} {
     max-height: 70vh;
  } */

The import statement for CloseIcon in the Modal component is incorrect. It should be imported as follows:

import CloseIcon from '../../../icons/close.svg';

All looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet