Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notification socket fix #1004

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

mohammeds1992
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@mohammeds1992 mohammeds1992 requested a review from Aman035 January 9, 2024 11:06
@mohammeds1992 mohammeds1992 linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jan 9, 2024

File: packages/restapi/src/lib/pushstream/PushStream.ts

  • Line 76: Remove unnecessary whitespace at the end of the log statement.
  • Line 90: Add a closing curly brace after the "throw new Error('Push chat socket not connected');" statement.
  • Line 97: Remove unnecessary whitespace at the end of the log statement.
  • Line 106: Add a closing curly brace after the "throw new Error('Push notification socket not connected');" statement.
  • Line 113: Remove unnecessary whitespace at the end of the log statement.
  • Line 117: Remove unnecessary whitespace at the end of the log statement.

File: packages/restapi/src/lib/pushstream/socketClient.ts

  • Line 57: Add a closing curly brace after the "console.error('[PUSH-SDK] - Socket connection error: ', e);" statement.

Copy link
Contributor

@madhur-push madhur-push left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mohammeds1992 mohammeds1992 merged commit 5ce3dfc into main Jan 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification socket not working
2 participants