fix: minor fix

push-protocol · Oct 9, 2023 · 15d5856 · 15d5856
1 parent a1caeaf
commit 15d5856
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/packages/restapi/src/lib/channels/signature.helpers.ts b/packages/restapi/src/lib/channels/signature.helpers.ts
@@ -30,7 +30,7 @@ export const getSubscriptionMessageV2 = (
   channel: string,
   userAddress: string,
   action: channelActionType,
-  userSetting?: string
+  userSetting?: string | null
 ) => {
   const actionTypeKey =
     action === 'Unsubscribe' ? 'unsubscriber' : 'subscriber';

diff --git a/packages/restapi/src/lib/channels/subscribeV2.ts b/packages/restapi/src/lib/channels/subscribeV2.ts
@@ -17,7 +17,7 @@ export type SubscribeOptionsV2Type = {
   signer: SignerType;
   channelAddress: string;
   userAddress: string;
-  settings?: string;
+  settings?: string | null;
   verifyingContractAddress?: string;
   env?: ENV;
   onSuccess?: () => void;

diff --git a/packages/restapi/src/lib/pushNotification/pushNotificationBase.ts b/packages/restapi/src/lib/pushNotification/pushNotificationBase.ts
@@ -701,6 +701,9 @@ export class PushNotificationBaseClass {
   }
 
   protected getMinimalUserSetting(setting: UserSetting[]) {
+    if(!setting){
+      return null;
+    }
     let userSetting = '';
     let numberOfSettings = 0;
     for (let i = 0; i < setting.length; i++) {

diff --git a/...i/tests/lib/pushNotification/base.test.ts → ...ests/lib/pushNotification/onchain.test.ts b/...i/tests/lib/pushNotification/base.test.ts → ...ests/lib/pushNotification/onchain.test.ts