Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAPP-1967-bonus-activity-container-position-fix #1968

Merged
merged 2 commits into from
Nov 12, 2024
Merged

DAPP-1967-bonus-activity-container-position-fix #1968

merged 2 commits into from
Nov 12, 2024

Conversation

rohitmalhotra1420
Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 commented Nov 12, 2024 •
edited
Loading

Pull Request Template

Ticket Number

Description

  • Fixed the position of the bonus activities container

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@rohitmalhotra1420 rohitmalhotra1420 added the Quick PR A PR that can be approved before finishing a coffee label Nov 12, 2024
@rohitmalhotra1420 rohitmalhotra1420 self-assigned this Nov 12, 2024
@github-actions GitHub Actions
Copy link

All looks good.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 12, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-11-12 11:49 UTC

corlard3y
corlard3y previously approved these changes Nov 12, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

All looks good.

@rohitmalhotra1420 rohitmalhotra1420 merged commit f769f86 into main Nov 12, 2024
2 checks passed
@rohitmalhotra1420 rohitmalhotra1420 linked an issue Nov 12, 2024 that may be closed by this pull request
Change position of bonus activities on reward page #1967
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corlard3y corlard3y corlard3y left review comments

@meKushdeepSingh meKushdeepSingh Awaiting requested review from meKushdeepSingh

Assignees

@rohitmalhotra1420 rohitmalhotra1420

Labels
Quick PR A PR that can be approved before finishing a coffee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change position of bonus activities on reward page
2 participants
@rohitmalhotra1420 @corlard3y