In-App chat notifications

[mishramonalisha76]

Pull Request Template

Ticket Number

• 1868

Description

• Problem/Feature:

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

All looks good.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-11-07 08:21 UTC

[github-actions]

In the FillCircle component in FillCircle.tsx:

1. The width and height attributes should not be set to "inherit" but to specific values like "20" for a consistent size.
2. The stroke attribute is missing in the circle element.

In the Image component in Image.tsx:

1. Several path elements are missing the opening tag <path>.
2. The stroke attributes should be wrapped in the path tags.

In the Notification component in Notification.tsx:

1. The Notification component function is missing a return statement.
2. The notification object is not properly closed with curly braces.
3. There is an extra closing curly brace at the end of the file before exporting.

Other than these issues, the code structure and logic seem fine.

Please address the mentioned issues and run a thorough test before proceeding.

All looks good.

[github-actions]

All looks good.

[github-actions]

I have reviewed the code in the specified files:

• In FillCircle.tsx and Image.tsx files, there seems to be a formatting issue in the SVG paths. The paths are not correctly enclosed within <path> tags and there are missing <path> tags for some paths. The CircleFilled and Image components are also missing closing tags for some elements.

• In Notification.tsx, there is a missing closing bracket for the useGetGroupInfo function.

• In Common.utils.tsx, there is a missing closing bracket for the formatSubscriberCount function, and the isValidURL function is missing a closing bracket and a return statement.

• In Notification.types.ts, the closeOnTimeout property should be replaced with onAutoClose.

• There are several incomplete files and directories with no content or incomplete content.

Please make the necessary corrections and completion of the files and directories mentioned above. Let me know if you need further assistance.

[github-actions]

All looks good.

[github-actions]

All looks good.

[github-actions]

All looks good.