Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Rewards Points Optimization and Fixes #1932

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Conversation

corlard3y
Copy link
Collaborator

@corlard3y corlard3y commented Oct 22, 2024

Pull Request Template

#1930

Description

  • Problem/Feature:
  • Update Stake Reset End Date logic
  • Update Endpoints for Recent Activities/UsersSingleActivity from POST to GET requests to reduce the frequency of api calls made per render

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior
    Screenshot 2024-10-22 at 02 50 25
    Screenshot 2024-10-22 at 02 50 34

  • After: What's changed now

Screenshot 2024-10-21 at 14 01 06

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

Copy link

All looks good.

Copy link

github-actions bot commented Oct 22, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-23 16:00 UTC

Copy link

All looks good.

Copy link

All looks good.

Copy link

All looks good.

@abhishek-01k
Copy link
Collaborator

Looks good to me. Tested it out with @corlard3y . Can proceed with deployment.

@corlard3y corlard3y self-assigned this Oct 22, 2024
@HarshRajat HarshRajat merged commit 09a5c16 into main Oct 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants