Inbox page lazy import commented

[rohitmalhotra1420]

Pull Request Template

Ticket Number

• Ticket Number

Description

• Fixed the inbox page lazy import for now to fix the inbox page breakage on prod

• Problem/Feature:

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

• There are some imports that are not being used, such as MdWarning, ToastContainer, AirdropPage, ChannelDashboardPage, ChannelsPage, ChatPage, and others. It's good practice to remove these unused imports.

• There is a commented-out import for InboxPage that is also being imported below. You should remove the commented-out import line.

• In the Routes component, some Route components are missing the closing /> tag. Make sure to add the closing tag for each Route element.

• There is a missing route definition for RewardsPointsPagePaths in the Routes component.

• The comment mentions reducing the number of pages for Snap to 1, but the code is still defining multiple paths for Snap. Make sure to update the routing logic accordingly.

• While using useContext(AppContext) on line 30 and 32, it seems you are trying to destructure multiple values at once from the context. The correct syntax for this would be:

  const { MetamaskPushSnapModalComponent, blockedLoading, showMetamaskPushSnap } = useContext(AppContext);

• Additionally, the logic of checking location.hash for '#receive-notifications' and calling showMetamaskPushSnap() seems to be missing a step to check if showMetamaskPushSnap is a function before calling it.

• The routing logic for some paths seems to be incorrect or missing. Make sure to verify and correct the paths defined in the Routes component.

After addressing these issues, please re-review the code for any other potential improvements or fixes.

[github-actions]

PR Preview Action v1.4.7
🚀 Deployed preview to https://push-protocol.github.io/push-dapp/pr-preview/pr-1931/
on branch gh-pages at 2024-10-18 15:44 UTC