Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUMP SDK IN DAPP] - Fixed the theme and twitter preview #1929

Merged
merged 3 commits into from
Oct 28, 2024
Merged

[BUMP SDK IN DAPP] - Fixed the theme and twitter preview #1929

merged 3 commits into from
Oct 28, 2024

Conversation

abhishek-01k
Copy link
Collaborator

Pull Request Template

Ticket Number

#1928

Description

  • Problem/Feature:

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

Screenshot 2024-10-16 at 3 56 23 PM

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@abhishek-01k abhishek-01k self-assigned this Oct 16, 2024
@github-actions GitHub Actions
Copy link

All looks good.

@abhishek-01k abhishek-01k linked an issue Oct 16, 2024 that may be closed by this pull request
🐛 [BUG] [BUMP SDK IN DAPP] - Fix font theme and twitter preview widget #1928
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-10-28 09:58 UTC

@github-actions GitHub Actions
Copy link

All looks good.

@github-actions GitHub Actions
Copy link

All looks good.

@rohitmalhotra1420 rohitmalhotra1420 merged commit e9e95de into main Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishramonalisha76 mishramonalisha76 mishramonalisha76 approved these changes

@rohitmalhotra1420 rohitmalhotra1420 rohitmalhotra1420 approved these changes

Assignees

@abhishek-01k abhishek-01k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] [BUMP SDK IN DAPP] - Fix font theme and twitter preview widget
3 participants
@abhishek-01k @rohitmalhotra1420 @mishramonalisha76