-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - [BUMP SDK IN DAPP] Group Info Modal UI issues #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All looks good. |
|
3 tasks
mishramonalisha76
previously approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out the changes. Looks good.
- Let's fix the merge conflicts.
- Create an alpha release and update this PR with that release.
- @abhishek-01k let me know when the first two points are done. I will go ahead and merge the PR.
rohitmalhotra1420
added
the
DO NOT MERGE
If the PR/task is dependent on some other task add this label to the PR.
label
Jun 3, 2024
abhishek-01k
dismissed
mishramonalisha76’s stale review
June 3, 2024 11:39
The merge-base changed after approval.
All looks good. |
All looks good. |
rohitmalhotra1420
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Group Info Modal:
Type of Change
Checklist
Frontend Guidelines
Build & Testing
Screenshots/Video with Explanation
Additional Context
Review & Approvals