Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - [BUMP SDK IN DAPP] Group Info Modal UI issues #1595

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

abhishek-01k
Copy link
Collaborator

@abhishek-01k abhishek-01k commented May 31, 2024

Description

In Group Info Modal:

  • When member list is loaded so scrollbar was not visible, now a single scrollbar is present for member list, pending member list and the parent.
  • In the Pending Member list dropdown, when the wallet address was copied so full address was not getting copied but half of the address was copied, fixed that too
  • In the same list, the tooltip saying copy wallet was not properly aligned so fixed that too.

Type of Change

  • Bug fix

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous
Screenshot 2024-05-31 at 5 31 30 PM
  • After: What's changed now
Screenshot 2024-05-31 at 5 30 38 PM

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Copy link

All looks good.

Copy link

github-actions bot commented May 31, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-06-03 13:33 UTC

@abhishek-01k abhishek-01k linked an issue May 31, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@rohitmalhotra1420 rohitmalhotra1420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out the changes. Looks good.

  • Let's fix the merge conflicts.
  • Create an alpha release and update this PR with that release.
  • @abhishek-01k let me know when the first two points are done. I will go ahead and merge the PR.

@rohitmalhotra1420 rohitmalhotra1420 added the DO NOT MERGE If the PR/task is dependent on some other task add this label to the PR. label Jun 3, 2024
@abhishek-01k abhishek-01k dismissed mishramonalisha76’s stale review June 3, 2024 11:39

The merge-base changed after approval.

Copy link

github-actions bot commented Jun 3, 2024

All looks good.

Copy link

github-actions bot commented Jun 3, 2024

All looks good.

@rohitmalhotra1420 rohitmalhotra1420 merged commit 236e753 into main Jun 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE If the PR/task is dependent on some other task add this label to the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - [BUMP SDK IN DAPP] Group Info Modal Minor UI issues fix
3 participants