Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the chatPreview list to chatview error #1588

Merged
merged 1 commit into from
May 31, 2024

Conversation

mishramonalisha76
Copy link
Collaborator

@mishramonalisha76 mishramonalisha76 commented May 29, 2024

Pull Request Template

Ticket Number

Description

  • Problem/Feature: It fixes switching from chat preview list to chat view for the same chat back to back in mobile view.

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@mishramonalisha76 mishramonalisha76 added the Quick PR A PR that can be approved before finishing a coffee label May 29, 2024
@mishramonalisha76 mishramonalisha76 self-assigned this May 29, 2024
Copy link

  • There is a missing closing brace } after isWallet = true;.
  • There are missing closing braces for each if block after the logic inside it.
  • setSelectedChatId(''); should be inside the useEffect block.
  • The logic inside the second useEffect block is not properly structured.
  • formattedchatId = reformatChatId(formattedchatId); should come before the if (formattedchatId) condition block.
  • The useNavigate() hook should be inside a functional component or a custom hook.
  • The userPushSDKInstance.stream check should be userPushSDKInstance?.stream.
  • The return chatid; statement should be outside the function body.

All in all, there are syntax errors, missing braces, and logic issues that need to be fixed in the code provided.

@mishramonalisha76 mishramonalisha76 linked an issue May 29, 2024 that may be closed by this pull request
Copy link

github-actions bot commented May 29, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-31 08:00 UTC

Copy link
Collaborator

@abhishek-01k abhishek-01k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Functionality working

@rohitmalhotra1420 rohitmalhotra1420 merged commit 5659b29 into main May 31, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick PR A PR that can be approved before finishing a coffee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Chat view to List view error - Mobile dApp
3 participants