Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space id integration #1585

Closed
wants to merge 1 commit into from
Closed

Space id integration #1585

wants to merge 1 commit into from

Conversation

mishramonalisha76
Copy link
Contributor

Pull Request Template

Ticket Number

Description

  • Problem/Feature: Enhanced the domain resolution process by using the space-id package. Now all domain supported by space-id can be resolved, including bnb , eth and unstoppable domains.

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@mishramonalisha76 mishramonalisha76 self-assigned this May 28, 2024
@github-actions GitHub Actions
Copy link

All looks good.

@mishramonalisha76 mishramonalisha76 added Quick PR A PR that can be approved before finishing a coffee DO NOT MERGE If the PR/task is dependent on some other task add this label to the PR. labels May 28, 2024
@mishramonalisha76 mishramonalisha76 changed the title added recent uiweb package Space id integration May 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2024 •
edited
Loading

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-28 10:34 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mishramonalisha76 mishramonalisha76

Labels
DO NOT MERGE If the PR/task is dependent on some other task add this label to the PR. Quick PR A PR that can be approved before finishing a coffee
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mishramonalisha76