🐛 [BUG] - [BUMP SDK IN DAPP] Skeleton loading in dark mode appears like light mode in chat #1584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All looks good. |
|
corlard3y
added
bug
rohitmalhotra1420
previously approved these changes
May 28, 2024
|
All looks good. |
rohitmalhotra1420
previously approved these changes
May 29, 2024
mishramonalisha76
requested changes
May 29, 2024
There was a problem hiding this comment.
Cannot see the change in dapp the colour seems different @corlard3y
@mishramonalisha76 Can we have a meet for this, so you can show me what you are referring to? |
corlard3y
dismissed stale reviews from mishramonalisha76 and rohitmalhotra1420
via
33690ad
|
All looks good. |
|
Bumped uiweb version to alpha |
rohitmalhotra1420
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
#1583
Description
Type of Change
Checklist
Frontend Guidelines
Build & Testing
Screenshots/Video with Explanation
Before:
Previous UI is using same theme as light mode, for dark mode theme
After:
Added different theme for the dark mode
Additional Context
The theme colours for the dark mode for the skeleton effect, should match other parts of the dApp according to the design team
Review & Approvals
Notes