added space-id

[rohitmalhotra1420]

Pull Request Template

Ticket Number

• Ticket Number

Description

• Problem/Feature:

Type of Change

• Bug fix
• New feature
• Code refactor
• Documentation update
• Other (please describe):

Checklist

• Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
  • Quick PR label added
• Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
  • DO NOT Merge PR label added

Frontend Guidelines

• Followed frontend guidelines as per the Guidelines Notion Doc

Build & Testing

• No errors in the build terminal
• Engineer has tested the changes on their local environment
• Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

• Before: Explain the previous behavior

• After: What's changed now

Additional Context

Review & Approvals

• Self-review completed
• Code review by at least one other engineer
• Documentation updates if applicable

Notes

[github-actions]

In the package.json file, I noticed a potential issue in the start script:

• In the "start" script:
  • The command "vite" is used, which may need to be preceded by yarn, i.e., "yarn vite".

Other than that, everything else in the package.json file looks good.

In the useResolveWeb3Name.ts file, everything looks good in terms of logic and structure.

The yarn.lock file is empty, which seems to be an issue. It should contain dependencies and their versions used in the project.

Overall, the code looks fine, except for the mention issues highlighted.

Once the mentioned issues are resolved, the code review is complete, and you can proceed with further tasks.

[github-actions]

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-27 15:34 UTC