Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate wallet display on alias chain #1574

Merged

Conversation

abhishek-01k
Copy link
Collaborator

@abhishek-01k abhishek-01k commented May 24, 2024

Pull Request Template

Ticket Number

#1573

Description

In Channel Dashboard, on Alias Chain delegates were not visible so fixed that.

  • Problem/Feature:

Type of Change

  • Bug fix

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

BEFORE: The Delegate Address is not visible.

Screenshot 2024-05-24 at 6 27 32 PM

After: The Delegate Address is not visible.

Screenshot 2024-05-24 at 6 28 42 PM

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

@abhishek-01k abhishek-01k self-assigned this May 24, 2024
Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) May 24, 2024 0:59am

Copy link

  1. In the useEffect hook, there are multiple asynchronous code blocks that are not properly structured within the hook's body. They should be wrapped inside an async function to avoid syntax errors.

  2. In the removeDelegate function, the return statement is missing a closing curly brace. It should be placed after the condition check for !userPushInstance.

  3. The navigateToNotifSettings function is missing a closing curly brace after calling the navigate function.

  4. There is a missing closing curly brace at the end of the file.

  5. There seems to be inconsistent indentation in some parts of the code.

  6. The use of conditional rendering for VerifyImage and AliasStateText components seems logical but should be thoroughly tested.

  7. There might be other logical issues or potential bugs that need to be properly reviewed.

Please make the necessary corrections and review the logic of the code.

Copy link

github-actions bot commented May 24, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-24 13:20 UTC

@rohitmalhotra1420 rohitmalhotra1420 added the Quick PR A PR that can be approved before finishing a coffee label May 24, 2024
@rohitmalhotra1420 rohitmalhotra1420 merged commit 5dfc3a6 into main May 24, 2024
3 of 5 checks passed
@abhishek-01k abhishek-01k linked an issue May 27, 2024 that may be closed by this pull request
@Aman035
Copy link
Member

Aman035 commented May 27, 2024

Hey
Verified with a couple of channels.
Working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quick PR A PR that can be approved before finishing a coffee
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Delegate of a channel is not visible on Alias Chain
3 participants