Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the uiweb version (1.0.0-exp.0) to fix chat blurr screen #1572

Closed
wants to merge 2 commits into from

Conversation

mishramonalisha76
Copy link
Collaborator

@mishramonalisha76 mishramonalisha76 commented May 24, 2024

Pull Request Template

Ticket Number

Description

Type of Change

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe):

Checklist

  • Quick PR: Is this a quick PR? Can be approved before finishing a coffee.
    • Quick PR label added
  • Not Merge Ready: Is this PR dependent on some other PR/tasks and not ready to be merged right now.
    • DO NOT Merge PR label added

Frontend Guidelines

Build & Testing

  • No errors in the build terminal
  • Engineer has tested the changes on their local environment
  • Engineer has tested the changes on deploy preview

Screenshots/Video with Explanation

  • Before: Explain the previous behavior

  • After: What's changed now

Additional Context

Review & Approvals

  • Self-review completed
  • Code review by at least one other engineer
  • Documentation updates if applicable

Notes

Copy link

vercel bot commented May 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
push-dapp ❌ Failed (Inspect) May 24, 2024 10:05am

@mishramonalisha76 mishramonalisha76 self-assigned this May 24, 2024
Copy link

All looks good.

@mishramonalisha76 mishramonalisha76 added bug Something isn't working Quick PR A PR that can be approved before finishing a coffee labels May 24, 2024
@mishramonalisha76 mishramonalisha76 linked an issue May 24, 2024 that may be closed by this pull request
@mishramonalisha76 mishramonalisha76 added feature enhancement Enhancement in existing feature and removed bug Something isn't working Quick PR A PR that can be approved before finishing a coffee labels May 27, 2024
@@ -10,7 +10,6 @@
"start:sdk:local:forcecleanup": "node dev-mode-link-local-sdk.mjs localsdk forcecleanup start",
"start:sdk:local:nocleanup": "node dev-mode-link-local-sdk.mjs localsdk nocleanup start",
"reset:sdk:prod": "node dev-mode-link-local-sdk.mjs prodsdk forcecleanup nostart",
"build:pr:preview": "node build.mjs preview && NODE_OPTIONS=--max-old-space-size=8192 vite build",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR not only updates the uiweb package but also:

  • Reinstalls all the unused libraries which I have already removed.
  • Removes the build:pr:preview command due to which you deploy preview is failing.
  • Downgrades the packageManager from 4.2.2 to 3.4.1 in package.json.

Please fix these changes your deploy preview should work after that. I would suggest to revert these changes, delete your node modules and remove the code in yarn.lock and then do a fresh yarn install.

@mishramonalisha76
Copy link
Collaborator Author

Solved in #1586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature enhancement Enhancement in existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUMP SDK IN DAPP] - Screen blur issue on chat screen 🐛 [BUG] - Screen blur issue on chat screen
2 participants