Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Setting Ticker #1279

Merged
merged 9 commits into from
Nov 3, 2023
Merged

Notification Setting Ticker #1279

merged 9 commits into from
Nov 3, 2023

Conversation

kalashshah
Copy link
Contributor

No description provided.

@kalashshah kalashshah requested a review from 0xNilesh October 18, 2023 09:45
@github-actions
Copy link

All looks good.

@github-actions
Copy link

All looks good.

@github-actions
Copy link

All looks good.

@github-actions
Copy link

All looks good.

@github-actions
Copy link

In the package.json file:

  • There is a typo in the "hompage" field. It should be "homepage".
  • The version of some dependencies is specified as "latest". It's recommended to use specific version numbers instead for more control over the dependencies.

In the SendNotifications.tsx file:

  • There is a typo in the import statement for "@web3-onboard/coinbase". It should be "@web3-react/coinbase".
  • The maxlength attribute in the <Input> component should be maxLength (capital "L").
  • The closing tag for the <InputSlider> component is missing.

In the ChannelInfoList.tsx file:

  • There is a missing closing tag for the <Item> component before the first occurrence of <NotificationSettingName>.
  • There is an unnecessary opening parenthesis after the return statement in the map function.
  • There is an unnecessary closing parenthesis after the second occurrence of <DelegateSettingsDropdown>.

Other files are not provided.

@0xNilesh 0xNilesh merged commit d50296a into main Nov 3, 2023
1 check passed
Copy link

github-actions bot commented Nov 3, 2023

File: package.json

  • The name "@pushprotocol/ledgerlive" requires verification as it is not a known package. Please confirm if this is the correct name or if it needs to be updated.

File: src/components/SendNotifications.tsx

  • Line 67: The closing tag for the onChange prop of DropdownStyled is missing.
  • Line 77: The closing tag for the Label component is missing.
  • Line 91: The closing tag for the Item component is missing.
  • Line 94: The closing tag for the Item component is missing.
  • Line 96: The opening tag for the Item component is missing.
  • Line 124: The closing tag for the Item component is missing.
  • Line 129: The closing tag for the Div component is missing.
  • Line 152: The closing tag for the Div component is missing.
  • Line 158: The opening tag for the Label component is missing.
  • Line 209: The closing tag for the Label component is missing.
  • Line 378: The closing tag for the Input component is missing.

File: src/components/channel/AddSettingModalContent.tsx

  • No mistakes found. All looks good.

File: src/components/channel/ChannelInfoList.tsx

  • Line 69: The closing tag for the DelegateInfoContainer is missing.
  • Line 82: The closing tag for the DelegateSettingsDropdown is missing.
  • Line 94: The closing tag for the DelegateSettingsDropdown is missing.
  • Line 97: The closing tag for the Item component is missing.
  • Line 114: The closing tag for the Item component is missing.
  • Line 132: The closing tag for the EmptyNotificationSettings component is missing.
  • Line 133: The closing tag for the Item component is missing.
  • Line 136: The closing tag for the DelegatesList component is missing.

File: src/components/channel/NotificationSettings.tsx

  • No mistakes found. All looks good.

File: src/components/dropdowns/OptinNotifSettingDropdown.tsx

  • No mistakes found. All looks good.

File: src/components/dropdowns/UpdateNotifSettingDropdown.tsx

  • No mistakes found. All looks good.

File: src/components/reusables/sliders/InputSlider.tsx

  • No mistakes found. All looks good.

File: src/components/userSettings/UserSettings.tsx

  • No mistakes found. All looks good.

File: src/config/Themization.js

  • No mistakes found. All looks good.

File: src/helpers/channel/InputValidation.ts

  • No mistakes found. All looks good.

File: src/helpers/channel/types.ts

  • Line 57: The closing brace of the ChannelSetting type is missing.
  • Line 62: The closing brace of the UserSetting type is missing.

File: yarn.lock

  • No mistakes found. All looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done and Merged
Development

Successfully merging this pull request may close these issues.

2 participants