Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snaps Issues resolved #1272

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Snaps Issues resolved #1272

merged 2 commits into from
Oct 16, 2023

Conversation

@github-actions
Copy link

All looks good.

Arch0125
Arch0125 previously approved these changes Oct 10, 2023
@github-actions
Copy link

File: src/components/MetamaskSnap/InstallMetamaskSnapModal.tsx

  • Line 23: "const installedSnaps = await window.ethereum.request({"
  • Line 26: "if (snap == 'npm:@pushprotocol/snap') {"
  • Line 77: "src={PushIcon}"
  • Line 106: "src={PlayStoreQRCode}"
  • Line 171: "src={AppleIcon}"
  • Line 173: "src={PlayStore}"

File: src/config/NavigationList.js

  • Line 137: "title: 'Yield Farming V2',"
  • Line 142: "title: 'Receive Notifications',"
  • Line 162: "isActive: true,"

File: src/modules/receiveNotifs/MetamaskPushSnapModal.tsx

  • Line 34: "const { setSnapState, SnapState } = React.useContext(AppContext);"
  • Line 43: "const handleCloseModal = () => {"
  • Line 56: " {SnapState == 1 && }"
  • Line 57: " {SnapState == 2 && }"
  • Line 60: " {SnapState == 3 && }"

File: src/structure/MasterInterfacePage.tsx

  • Line 54: "const { MetamaskPushSnapModalComponent }:AppContextType = React.useContext(AppContext);"
  • Line 55: "const { showMetamaskPushSnap } = React.useContext(AppContext);"
  • Line 61: "React.useEffect(()=>{"
  • Line 68: "{/* Modal displaying ReceiveNotifications */}"
  • Line 79: "MetamaskPushSnapModalComponent"
  • Line 80: "id='receive-notifications'"
  • Line 81: "InnerComponent={MetamaskPushSnapModal}"
  • Line 82: "modalPadding='0px'"
  • Line 83: "modalPosition={MODAL_POSITION.ON_ROOT}"

File: src/components/MetamaskSnap/InstallMetamaskSnapModal.tsx
All looks good.

File: src/config/NavigationList.js
All looks good.

File: src/modules/receiveNotifs/MetamaskPushSnapModal.tsx
All looks good.

File: src/structure/MasterInterfacePage.tsx
All looks good.

@0xNilesh 0xNilesh merged commit 6b68c7b into main Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done and Merged
Development

Successfully merging this pull request may close these issues.

3 participants