Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated new api and notif settings backend #1270

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

0xNilesh
Copy link
Member

No description provided.

@github-actions
Copy link

In package.json:

  • Line 4: The homepage URL should be changed to the correct URL of the project.
  • Lines 43-44: The version of '@mui/icons-material' package should be '^5.15.0' instead of '^5.8.4'.
  • Line 45: The version of '@mui/lab' package should be '^5.0.0-alpha.73' instead of '^5.0.0-alpha.72'.
  • Line 46: The version of '@mui/material' package should be '^5.5.4' instead of '^5.5.0'.
  • Lines 62-63: The version of '@pushprotocol/restapi' package should be '0.0.1-alpha.49' instead of '0.0.1-alpha.48'.
  • Lines 64-65: The version of '@pushprotocol/socket' package should be '0.0.1-alpha.10' instead of 'latest'.
  • Lines 66-67: The version of '@pushprotocol/uiweb' package should be '0.0.1-alpha.19' instead of '0.0.1-alpha.17'.
  • Line 123: The version of '@testing-library/react' package should be '^12.1.2' instead of '^9.3.2'.
  • Lines 194-196: The version of 'react-router-dom' package should be '^6.0.2' instead of '^6.0.0-next.1'.
  • Line 228: The version of 'typescript-eslint/parser' package should be '^8.6.0' instead of '^8.5.0'.
  • Line 272: The version of 'websocket' package should be '^1.0.35' instead of '^1.0.33'.

In src/components/ViewChannelItem.js:

  • Line 40: The closing ')' is missing for the 'ActionLoader' component.

In src/components/channel/NotificationSettings.tsx:

  • Line 36: The closing '}' is missing for the 'if (_notifDescription !== '')' check in the forEach loop.
  • Line 43: The closing '}' is missing for the 'saveSettings' function.

In src/components/dropdowns/DropdownBtnHandler.tsx:

  • Line 40: The closing '}' is missing for the 'if (index === -1)' check in the 'addSetting' function.

In src/contexts/AppContext.tsx:

  • Line 61: The closing '}' is missing for the 'initializePushSDK' function.

That's all. All looks good.

@0xNilesh 0xNilesh requested a review from kalashshah October 10, 2023 08:48
@github-actions
Copy link

File: package.json

All looks good.

File: src/components/ViewChannelItem.js

  1. Line 39: The closing parenthesis for the ActionLoader component is missing. Add ) at the end of line 39.

  2. Line 63: The closing parenthesis for the SubscribeButton component is missing. Add ) at the end of line 63.

  3. Line 77: The closing parenthesis for the UnsubscribeButton component is missing. Add ) at the end of line 77.

  4. Line 91: The closing parenthesis for the OptinNotifSettingDropdown component is missing. Add ) at the end of line 91.

  5. Line 123: The closing parenthesis for the ManageNotifSettingDropdown component is missing. Add ) at the end of line 123.

  6. Line 142: The closing parenthesis for the NotificationToast component is missing. Add ) at the end of line 142.

File: src/components/channel/UserSettings.tsx

  1. Line 61: The opening brace { for the fillData function is missing before the useEffect hook. Add { at the beginning of line 61.

  2. Line 107: The closing parenthesis for the navigateToChannels function is missing. Add ) at the end of line 107.

  3. Line 122: The opening brace { for the Wrapper component is missing. Add { at the beginning of line 122.

  4. Line 141: The closing parenthesis for the sendOptIn function is missing. Add ) at the end of line 141.

  5. Line 148: The closing parenthesis for the ManageNotifSettingDropdown component is missing. Add ) at the end of line 148.

File: src/components/dropdowns/DropdownBtnHandler.tsx

All looks good.

File: src/components/dropdowns/ManageNotifSettingDropdown.tsx

All looks good.

File: src/components/dropdowns/OptinNotifSettingDropdown.tsx

All looks good.

File: src/components/dropdowns/UpdateNotifSettingDropdown.tsx

All looks good.

File: src/contexts/AppContext.tsx

All looks good.

File: src/helpers/channel/notifSetting.ts

All looks good.

File: src/helpers/channel/types.ts

All looks good.

File: src/types/context.ts

All looks good.

File: yarn.lock

All looks good.

@github-actions
Copy link

All looks good.

@github-actions
Copy link

All looks good.

Copy link
Contributor

@kalashshah kalashshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xNilesh 0xNilesh merged commit 829d009 into feat/notif-settings Oct 10, 2023
1 check passed
@0xNilesh 0xNilesh deleted the refactor/settings-integration branch October 10, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done and Merged
Development

Successfully merging this pull request may close these issues.

2 participants