Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created /snap route #1254

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Created /snap route #1254

merged 3 commits into from
Sep 18, 2023

Conversation

abhishek-01k
Copy link
Collaborator

No description provided.

@abhishek-01k abhishek-01k changed the base branch from main to metamask-snap-ui September 17, 2023 17:06
@github-actions
Copy link

File: src/assets/PushSnaps/ActiveIcon.svg - All looks good.

File: src/assets/PushSnaps/Gear.svg - All looks good.

File: src/assets/PushSnaps/PushMetamaskLogo.svg - Empty file.

File: src/assets/PushSnaps/SnapExample.svg - Empty file.

File: src/assets/PushSnaps/spam-icon.svg - All looks good.

File: src/components/MetamaskSnap/SnapInformationModal.tsx - Code is missing. There is an incomplete block at line 41.

File: src/config/NavigationList.js - There are missing closing brackets for 'third', 'pushSnaps', 'receiveNotifs' objects.

File: src/modules/receiveNotifs/ReceiveNotifsModule.tsx - All looks good.

File: src/modules/snap/AboutSnapModal.tsx - There are missing closing brackets for object 'info' in 'InfoDetails' array.

File: src/modules/snap/PushSnapModal.tsx - File is missing.

File: src/modules/snap/SnapModule.tsx - File is missing.

File: src/pages/SnapPage.tsx - All looks good.

File: src/structure/MasterInterface

@github-actions
Copy link

File: src/assets/PushSnaps/PushMetamaskLogo.svg - Empty file.

File: src/config/NavigationList.js - No issues found.

File: src/modules/snap/AboutSnapModal.tsx -

  1. In the InfoDetails array, there are missing opening and closing braces for each object.
  2. The fontSize and fontWeight values in the H2V2 component should be enclosed in quotes.

File: src/modules/snap/PushSnapModal.tsx -

  1. In the FilledButton component, there is a duplicate border-radius property.
  2. There is an extra closing brace in the ButtonHV2 component.

File: src/modules/snap/SnapModule.tsx - No issues found.

File: src/pages/SnapPage.tsx - No issues found.

File: src/structure/MasterInterfacePage.tsx -

  1. Multiple import statements are commented out. These can be removed.
  2. The import for SnapPage is missing.

All looks good.

Copy link
Contributor

@Arch0125 Arch0125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Arch0125 Arch0125 merged commit 9a90451 into metamask-snap-ui Sep 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done and Merged
Development

Successfully merging this pull request may close these issues.

2 participants