fix: fixed addDelegate and removeDelegate emitting events when not ne…

…cessary
push-protocol · Nov 20, 2024 · 6bcf5ba · 6bcf5ba
1 parent e5ff018
commit 6bcf5ba
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/src/lib.cairo b/src/lib.cairo
@@ -348,14 +348,20 @@ pub mod PushComm {
 
         fn add_delegate(ref self: ContractState, delegate: ContractAddress) {
             let channel = get_caller_address();
-            self.delegated_notification_senders.entry(channel).write(delegate, true);
-            self.emit(AddDelegate { channel: channel, delegate: delegate });
+
+            if !self.delegated_notification_senders.entry(channel).entry(delegate).read() {
+                self.delegated_notification_senders.entry(channel).write(delegate, true);
+                self.emit(AddDelegate { channel: channel, delegate: delegate });
+            } 
         }
 
         fn remove_delegate(ref self: ContractState, delegate: ContractAddress) {
             let channel = get_caller_address();
-            self.delegated_notification_senders.entry(channel).write(delegate, false);
-            self.emit(RemoveDelegate { channel: channel, delegate: delegate });
+
+            if self.delegated_notification_senders.entry(channel).entry(delegate).read() {
+                self.delegated_notification_senders.entry(channel).write(delegate, false);
+                self.emit(RemoveDelegate { channel: channel, delegate: delegate });
+            }
         }
 
         fn send_notification(