fix: fixed unused variables and typo (#19)

push-protocol · Nov 20, 2024 · 526d127 · 526d127
1 parent 0e4778b
commit 526d127
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/lib.cairo b/src/lib.cairo
@@ -47,7 +47,6 @@ pub mod PushComm {
         delegated_notification_senders: Map<ContractAddress, Map<ContractAddress, bool>>,
         // Contract State
         governance: ContractAddress,
-        push_core_address: EthAddress,
         push_token_address: ContractAddress,
         // Chain Info
         chain_name: felt252,
@@ -76,7 +75,7 @@ pub mod PushComm {
         AddDelegate: AddDelegate,
         RemoveDelegate: RemoveDelegate,
         SendNotification: SendNotification,
-        UserNotifcationSettingsAdded: UserNotifcationSettingsAdded
+        UserNotificationSettingsAdded: UserNotificationSettingsAdded
     }
 
     #[derive(Drop, starknet::Event)]
@@ -131,7 +130,7 @@ pub mod PushComm {
     }
 
     #[derive(Drop, starknet::Event)]
-    pub struct UserNotifcationSettingsAdded {
+    pub struct UserNotificationSettingsAdded {
         #[key]
         pub channel: ContractAddress,
         #[key]
@@ -244,7 +243,7 @@ pub mod PushComm {
         }
 
         fn _check_notif_req(
-            self: @ContractState, channel: ContractAddress, recipient: ContractAddress
+            self: @ContractState, channel: ContractAddress
         ) -> bool {
             let caller_address = get_caller_address();
 
@@ -262,7 +261,7 @@ pub mod PushComm {
             recipient: ContractAddress,
             identity: ByteArray
         ) -> bool {
-            let success = self._check_notif_req(channel, recipient);
+            let success = self._check_notif_req(channel);
             if success {
                 self
                     .emit(
@@ -320,7 +319,7 @@ pub mod PushComm {
 
             self
                 .emit(
-                    UserNotifcationSettingsAdded {
+                    UserNotificationSettingsAdded {
                         channel: channel,
                         recipient: caller_address,
                         notif_id: notif_id,

diff --git a/tests/test_channel_settings.cairo b/tests/test_channel_settings.cairo
@@ -29,7 +29,7 @@ fn test_channel_channel_user_settings() {
     let setting_saved = push_comm.user_to_channel_notifs(USER_1(), CHANNEL_ADDRESS);
     assert(setting_saved == modified_notif_settings, 'Settings saved');
 
-    // Assert UserNotifcationSettingsAdded event was emitted
+    // Assert UserNotificationSettingsAdded event was emitted
     spy
         .assert_emitted(
             @array![