test: ignore colors in e2e #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apparently wdio does support ignoring colors when comparing images.
Under the hood
wdio-visual-regression-serviceusesnode-resemble-jsto compare images which supports ignoring images.Even they have support for it: https://github.com/zinserjan/wdio-visual-regression-service/blob/ddf272edddf46fbde4b01e86804c1449ba580123/src/methods/LocalCompare.js#L71
But the property is missing from the constructor so I forked and I added it. (zinserjan/wdio-visual-regression-service#45)
you can pass
colorsorantialiasingand that will be ignored.