Remove default keyword
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wouldn't trust an AI even slightly for things like this, but I looked around in GitHub and there's no indication that |
I just stumbled upon a code in PS `routing-duplex`, where `default` is a function name and it's getting highlighted. That made me dig to see where such keyword could be used to reduce the possibility of such false-positives. Now, I personally don't remember `default` being ever used as a keyword in PS. So I asked an AI but it doesn't know either. Then as a last measure I looked at syntax highlight in VS Code editor, and they don't highlight `default` either. So remove `default` from the list of keywords.
Hi-Angel
force-pushed
the
rm-default-keyword
branch
from
fae74b7 to
e36b995
Compare
|
Thank you, done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just stumbled upon a code in PS
routing-duplex, wheredefaultis a function name and it's getting highlighted. That made me dig to see where such keyword could be used to reduce the possibility of such false-positives.Now, I personally don't remember
defaultbeing ever used as a keyword in PS. So I asked an AI but it doesn't know either. Then as a last measure I looked at syntax highlight in VS Code editor, and they don't highlightdefaulteither.So remove
defaultfrom the list of keywords.