Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement going to the beginning of a defun #26

Merged

Conversation

Hi-Angel
Copy link
Contributor

@Hi-Angel Hi-Angel commented Nov 5, 2024

This implements support for (beginning-of-defun). As a side note, the match is done inside a single line string because I tried implementing a regexp to make Emacs to restrain to a single line, and it turned out to be very hard. I didn't succeed at that for like ½-hour I spent on that part, and constraining the search artifically turned out not just much easier, but also significantly simplified the regexp.

@Hi-Angel
Copy link
Contributor Author

Hi-Angel commented Nov 5, 2024

What… older Emacses doesn't know anychar in rx. What's that supposed to be then… anything? It said to be an alias

@Hi-Angel Hi-Angel force-pushed the implement-defun-beginning branch from 1d8f87d to c1e7ffe Compare November 5, 2024 21:31
@Hi-Angel
Copy link
Contributor Author

Hi-Angel commented Nov 5, 2024

Okay, anything did work

@Hi-Angel Hi-Angel force-pushed the implement-defun-beginning branch from c1e7ffe to 6a7d460 Compare November 5, 2024 22:19
This implements support for `(beginning-of-defun)`. As a side note,
the match is done inside a single line string because I tried
implementing a regexp to make Emacs to restrain to a single line, and
it turned out to be very hard. I didn't succeed at that for like
½-hour I spent, and constraining the search artifically turned out not
just much easier, but also significantly simplified the regexp.
@Hi-Angel Hi-Angel force-pushed the implement-defun-beginning branch from 6a7d460 to b6d68e3 Compare November 6, 2024 11:20
@purcell purcell merged commit b2184fb into purescript-emacs:master Dec 9, 2024
10 checks passed
@purcell
Copy link
Member

purcell commented Dec 9, 2024

Nice, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants