Fixing all byte-compilation errors #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes warnings:
purescript-font-lock.el:448:2: Error: docstring has wrong usage of unescaped single quotes (use \=' or different quoting such as `...')
purescript-indent.el:1321:2: Error: docstring has wrong usage of unescaped single quotes (use \=' or different quoting such as `...')
purescript-mode.el:88:2: Error: docstring has wrong usage of unescaped single quotes (use \=' or different quoting such as `...')
It's reserved for unused variables. Fixes a warning:
purescript-mode.el:63:11: Error: variable ‘_version’ not left unused
Fixes:
purescript-indent.el:437:19: Error: Unused lexical variable ‘errlist’
purescript-indent.el:1295:34: Error: Unused lexical argument ‘start’
purescript-mode.el:416:44: Error: Unused lexical argument ‘info’
Fixes:
purescript-navigate-imports.el:101:12: Error: Unused lexical variable ‘point’
purescript-simple-indent.el:146:10: Error: Unused lexical variable ‘point’
Fixes:
purescript-sort-imports.el:41:4: Error: Doc string after ‘interactive’
Upstream Emacs has made lack of the directive a warning. So enable it
explicitly everywhere. It provides various benefits such as better
introspection by the compiler into the code and optimizations.
Fixes a bunch of warnings:
Error: file has no ‘lexical-binding’ directive on its first line
Hi-Angel
force-pushed
the
make-ci-pass
branch
from
3e1058c to
9a9f550
Compare
Though I have two separate commits for fixing "unused lexical variable": one is a trivial rename of the arguments, and the other is removing let-bindings with a unused variable. The latter involves changing indentation, so I figured if there'd be a regression, would be better to have this change separated (but ofc hopefully there won't be any, shouldn't be at least 😊). |
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion here, I decided to fix byte-compilation errors that are currently present in the package. As a bonus, this enables lexical binding everywhere, so Emacs will have better introspection into the package, thus enabling more optimizations.
Each error is being fixed in its own commit.
On my latest Emacs from upstream this branch currently passes with no errors.