purescript-indentation.el: don't modify buffer if indentation unchanged #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently calling indentation on a line that is already indented as expected results in buffer being modified despite no changes being actually done. Avoid this by checking if current indentation already matches the one we just calculated and only reindenting on mismatch.
|
Ping? |
|
Hey I approved running the CI and see some failures in there. Do you think you could look into fixing them? I'm happy to press merge then. thanks! |
kritzcreek
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently calling indentation on a line that is already indented as expected results in buffer being modified despite no changes being actually done. Avoid this by checking if current indentation already matches the one we just calculated and only reindenting on mismatch.