Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wireplumber_FIXUPHACK: Disable active login session monitoring #4261

Open
wants to merge 4 commits into
base: testing
Choose a base branch
from

Conversation

rizalmart
Copy link
Contributor

wireplumber-0.5 onwards now looks for active login session in order to make bluez work on pipewire otherwise bluetooth devices will not work on pipewire since Puppy has no display manager

See https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3828

wireplumber-0.5 onwards now looks for active login session in order to make bluez work on pipewire otherwise bluetooth devices will not work on pipewire since Puppy has no display manager

See [https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3828](https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3828)
@rizalmart rizalmart changed the title Update wireplumber_FIXUPHACK: Disable active session monitoring Update wireplumber_FIXUPHACK: Disable active login session monitoring Mar 24, 2024
@peabee
Copy link
Contributor

peabee commented Mar 25, 2024

Should be a test whether /etc/wireplumber/wireplumber.conf.d/bluez-nologind.conf exists before overwriting?

Should be a comment to say why the file is needed.

@rizalmart
Copy link
Contributor Author

Should be a test whether /etc/wireplumber/wireplumber.conf.d/bluez-nologind.conf exists before overwriting?

Should be a comment to say why the file is needed.

Commit revised

@peabee
Copy link
Contributor

peabee commented Mar 26, 2024

?? Missing !
As written would only work if the file exists to be overwritten?

@peabee
Copy link
Contributor

peabee commented Mar 26, 2024

Remove / from all /etc

@@ -1,9 +1,14 @@
rm -f `find . -name libwireplumber-module-logind.so` 2>/dev/null

if [ -f /etc/wireplumber/wireplumber.conf.d/bluez-nologind.conf ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relative path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does FIXUPHACK scripts are chrooted process?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rizalmart, nope.

@@ -1,6 +1,6 @@
rm -f `find . -name libwireplumber-module-logind.so` 2>/dev/null

if [ -f /etc/wireplumber/wireplumber.conf.d/bluez-nologind.conf ]; then
if [ ! -f /etc/wireplumber/wireplumber.conf.d/bluez-nologind.conf ]; then

#Enable bluez without session from display manager. Puppy has no display manager
cat << EOF > /etc/wireplumber/wireplumber.conf.d/bluez-nologind.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, should be relative to package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script revised. Please check

@peabee
Copy link
Contributor

peabee commented Apr 1, 2024

Is this now ready to merge? tested?

@rizalmart
Copy link
Contributor Author

rizalmart commented Apr 1, 2024

Is this now ready to merge? tested?

The config file was fully tested.

To recreate the problem with wireplumber.

  1. update wireplumber to version 0.5 using default config
  2. restart pc
  3. try to connect on bluetooth device

@peabee
Copy link
Contributor

peabee commented Apr 1, 2024

Has the new packages-templates/wireplumber_FIXUPHACK been tested in a 2createpackages of wireplumber?

@peabee
Copy link
Contributor

peabee commented Apr 11, 2024

Bump:
Has the new packages-templates/wireplumber_FIXUPHACK been tested in a 2createpackages of wireplumber?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants