-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wireplumber_FIXUPHACK: Disable active login session monitoring #4261
base: testing
Are you sure you want to change the base?
Conversation
wireplumber-0.5 onwards now looks for active login session in order to make bluez work on pipewire otherwise bluetooth devices will not work on pipewire since Puppy has no display manager See [https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3828](https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3828)
Should be a test whether /etc/wireplumber/wireplumber.conf.d/bluez-nologind.conf exists before overwriting? Should be a comment to say why the file is needed. |
Commit revised |
?? Missing ! |
Remove / from all /etc |
@@ -1,9 +1,14 @@ | |||
rm -f `find . -name libwireplumber-module-logind.so` 2>/dev/null | |||
|
|||
if [ -f /etc/wireplumber/wireplumber.conf.d/bluez-nologind.conf ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relative path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does FIXUPHACK scripts are chrooted process?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rizalmart, nope.
some bugfixes
@@ -1,6 +1,6 @@ | |||
rm -f `find . -name libwireplumber-module-logind.so` 2>/dev/null | |||
|
|||
if [ -f /etc/wireplumber/wireplumber.conf.d/bluez-nologind.conf ]; then | |||
if [ ! -f /etc/wireplumber/wireplumber.conf.d/bluez-nologind.conf ]; then | |||
|
|||
#Enable bluez without session from display manager. Puppy has no display manager | |||
cat << EOF > /etc/wireplumber/wireplumber.conf.d/bluez-nologind.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here, should be relative to package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script revised. Please check
Is this now ready to merge? tested? |
The config file was fully tested. To recreate the problem with wireplumber.
|
Has the new packages-templates/wireplumber_FIXUPHACK been tested in a 2createpackages of wireplumber? |
Bump: |
wireplumber-0.5 onwards now looks for active login session in order to make bluez work on pipewire otherwise bluetooth devices will not work on pipewire since Puppy has no display manager
See https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/3828