(PA-5786) Add ability to execute direct post installation scriptlets #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvpartytonight
force-pushed
the
PA-5786_alt
branch
from
c763b1f to
8365247
Compare
|
This might be preferable to #819 as it should be safer and would only affect projects using |
tvpartytonight
force-pushed
the
PA-5786_alt
branch
from
8365247 to
d5e6980
Compare
joshcooper
approved these changes
Oct 20, 2023
e-gris
approved these changes
Oct 23, 2023
lib/vanagon/component/dsl.rb
Outdated
Comment on lines
512
to
513
| pkg_state = Array(pkg_state) | ||
| scripts = Array(scripts) |
There was a problem hiding this comment.
Style only: don't mutate caller-supplied arguments; create new variables instead.
lib/vanagon/project.rb
Outdated
| scripts = components.flat_map(&:postinstall_required_actions).compact.select { |s| s.pkg_state.include? pkg_state }.map(&:scripts) | ||
| if scripts.empty? | ||
| return ': no postinstall required scripts provided' | ||
| else |
There was a problem hiding this comment.
Style only: else is redundant. Favor a guardian clause:
return ': no postinstall required scripts provided' if scripts.empty?
[return] scripts.join("\n")The 2nd return is optional depending on your aesthetic preferences.
tvpartytonight
commented
Oct 23, 2023
lib/vanagon/project.rb
Outdated
| @@ -485,7 +485,7 @@ def get_activate_triggers() | |||
| # Can be one of 'install' or 'upgrade' | |||
| # @return [String] string of Bourne shell compatible scriptlets to execute during the postinstall | |||
| # phase of packaging during the state of the system defined by pkg_state (either install or upgrade) | |||
| def get_postinstall_actions(pkg_state) | |||
| def get_postinstall_required_actions(pkg_state) | |||
There was a problem hiding this comment.
This is titled incorrectly and should be the name of the function below.
tvpartytonight
force-pushed
the
PA-5786_alt
branch
2 times, most recently
from
898dfaf to
1f169dc
Compare
|
Also, when ready, please add a CHANGELOG update. |
tvpartytonight
force-pushed
the
PA-5786_alt
branch
from
1f169dc to
a4045d5
Compare
|
@e-gris I think I have address all comments, let me know if there is anything I missed. |
|
Put an '### Added' header above the changelog entry and all will be well. |
The existing `#add_postinstall_action` adds actions to the `%posttrans` section of an rpm spec file. This can mean that the action could fail, but the installation/upgrade could still succeed. This commit adds the ability to add actions that must succeed post installation for rpm installations by adding the action to the `%post` section.
tvpartytonight
force-pushed
the
PA-5786_alt
branch
from
a4045d5 to
93ba1b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
#add_postinstall_actionadds actions to the%posttranssection of an rpm spec file. This can mean that the action could fail, but the installation/upgrade could still succeed. This commit adds the ability to add actions that must succeed post installation for rpm installations by adding the action to the%postsection.Please add all notable changes to the "Unreleased" section of the CHANGELOG.