Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a mode parameter to manage repository root directory permission #599

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a mode parameter to manage repository root directory permission #599

wants to merge 1 commit into from

Conversation

robbat2
Copy link

@robbat2 robbat2 commented Apr 9, 2023

Add a mode option per #598 feature request.

Reference: #598

@robbat2 robbat2 requested a review from a team as a code owner April 9, 2023 22:15
@puppet-community-rangefinder
Copy link

vcsrepo is a type

Breaking changes to this file WILL impact these 182 modules (exact match):
Breaking changes to this file MAY impact these 66 modules (near match):

This module is declared in 111 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@robbat2
Copy link
Author

robbat2 commented Apr 22, 2023

@david22swan can this be merged please?

@LukasAud
Copy link

Hey @robbat2, this Pull Request needs a rebase and conflict resolution. Once that is done, I will be happy to review.

@robbat2
Copy link
Author

robbat2 commented Jul 1, 2023

Rebased now, watching to see that CI passes

@robbat2
Copy link
Author

robbat2 commented Jul 3, 2023

@LukasAud can you approve it for CI please?

smortex
smortex reviewed Jul 13, 2023
View reviewed changes
lib/puppet/provider/vcsrepo.rb Outdated Show resolved Hide resolved
lib/puppet/provider/vcsrepo.rb Outdated Show resolved Hide resolved
@smortex smortex changed the title vcsrepo: add mode option Add a mode parameter to manage repository root directory permission Jul 13, 2023
@robbat2
vcsrepo: add mode option
051baa1 
Splits set_ownership_and_permissions into seperate functions per
Metrics/CyclomaticComplexity & Metrics/PerceivedComplexity rubocop
checks.

Signed-off-by: Robin H. Johnson <[email protected]>
Reference: puppetlabs#598
@robbat2
Copy link
Author

robbat2 commented Jul 13, 2023

@smortex fixed those issues as part of a rebase, plus the rubocop style checks. Please approve CI again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smortex smortex smortex left review comments

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robbat2 @CLAassistant @LukasAud @smortex @ia-content