use a guard clause

puppetlabs · Aug 11, 2022 · ba2cdda · ba2cdda
1 parent bc10fa1
commit ba2cdda
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/lib/puppet/provider/vcsrepo/git.rb b/lib/puppet/provider/vcsrepo/git.rb
@@ -642,11 +642,11 @@ def add_safe_directory
 
   # @!visibility private
   def remove_safe_directory
-    if safe_directories.include?(@resource.value(:path))
-      notice("Removing '#{@resource.value(:path)}' from safe directory list")
-      args = ['config', '--global', '--unset', 'safe.directory', @resource.value(:path)]
-      git_with_identity(*args)
-    end
+    return if safe_directories.include?(@resource.value(:path))
+
+    notice("Removing '#{@resource.value(:path)}' from safe directory list")
+    args = ['config', '--global', '--unset', 'safe.directory', @resource.value(:path)]
+    git_with_identity(*args)
   end
 
   # @!visibility private