-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set data types for puppetdb parameters #411
Open
chambersmp
wants to merge
32
commits into
puppetlabs:main
Choose a base branch
from
chambersmp:feature_data_validation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chambersmp
requested review from
bastelfreak,
smortex,
h0tw1r3 and
a team
as code owners
May 29, 2024 04:59
bastelfreak
reviewed
May 29, 2024
h0tw1r3
approved these changes
May 31, 2024
smortex
reviewed
Jun 10, 2024
FWIW, I would remove the maintenance label so the change does show up in the change log and release notes. |
bastelfreak
reviewed
Jun 28, 2024
As open_ssl_listen_port is no longer |
h0tw1r3
approved these changes
Jul 9, 2024
smortex
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enable data type validation for parameters in puppetdb classes and defined types. The goal is to refine user inputs to reduce risk of misconfiguration or failure to apply.
Each data type was configured based on default values supplied within the params.pp class, unit/acceptance tests and alternative values recommended in PuppetDB docs.
Changes:
Stdlib::Host
,Stdlib::Port::User
)Potential for Breaking Change:
Variant
to support historicalString
usage withPattern
matchingRelated Issues:
resolves #105
Testing: