feature: add frozen string magic comment #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puppetlabs-augeas_core and puppet-augeasproviders_core both provide the augeas feature. However the both have slightly different files (this lacking the frozen strings magic comment. This causes puppet to perform a change on every puppet run. This PR updates the feature in this repo to add the magic comment so both files match. More then happy to explore alternate fixes
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
Apr 28, 2023
This is a patch to fix an on going issue. it will be removed the next time we upgrade augeas_core. but hopefully an upstream fix[1] is in place by then [1]puppetlabs/puppetlabs-augeas_core#60 Bug: T335572 Change-Id: Icba3720beef1a317a9890c17b85106d7f041118e
|
This is something we also observe in our environment. Would be excellent to have this fixed! :) |
|
Thank you for your contribution @b4ldr ! I'm going to close then re-open this PR to rekick checks. |
wmfgerrit
pushed a commit
to wikimedia/operations-puppet
that referenced
this pull request
Oct 3, 2023
Most changes related to guthub actions rake tasks or pdk templates see full change list[1] for more details. However ti dose include a very minor fix from us[2] [1]puppetlabs/puppetlabs-augeas_core@v1.2.0...v1.4.1 [2]puppetlabs/puppetlabs-augeas_core#60 Change-Id: I631a80b19172b51a0e4c1c7635709157fec5e02c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
puppetlabs-augeas_core and puppet-augeasproviders_core both provide the augeas feature. However the both have slightly different files (this lacking the frozen strings magic comment. This causes puppet to perform a change on every puppet run.
This PR updates the feature in this repo to add the magic comment so both files match. More then happy to explore alternate fixes