Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable PSF to variable PSF transforms #203

Merged
merged 4 commits into from
Aug 18, 2024
Merged

Add variable PSF to variable PSF transforms #203

merged 4 commits into from
Aug 18, 2024

Conversation

jmbhughes
Copy link
Member

@jmbhughes jmbhughes commented Aug 11, 2024

PR summary

This allows a variable PSF to be the target.

Todos

None

Test plan

Unit tests pass. And works for creating PUNCH synthetic images.

Breaking changes

File format save is different now.

Related Issues

None

@jmbhughes jmbhughes self-assigned this Aug 11, 2024
Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 71.81818% with 31 lines in your changes missing coverage. Please review.

Project coverage is 93.50%. Comparing base (cc937ef) to head (c40f2bb).
Report is 7 commits behind head on main.

Files Patch % Lines
regularizepsf/fitter.py 57.57% 14 Missing ⚠️
regularizepsf/psf.py 62.50% 9 Missing ⚠️
regularizepsf/corrector.py 89.36% 5 Missing ⚠️
regularizepsf/visualize.py 0.00% 2 Missing ⚠️
tests/test_corrector.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   95.19%   93.50%   -1.70%     
==========================================
  Files          10       10              
  Lines        1020     1062      +42     
==========================================
+ Hits          971      993      +22     
- Misses         49       69      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes jmbhughes changed the title Release a new stable version Add variable PSF to variable PSF transforms Aug 13, 2024
@jmbhughes jmbhughes marked this pull request as ready for review August 18, 2024 21:09
@jmbhughes jmbhughes merged commit a18b4c3 into main Aug 18, 2024
6 of 8 checks passed
@jmbhughes jmbhughes deleted the v1 branch August 18, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant