Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully implement previous change to bounding boxes #332

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

svank
Copy link
Contributor

@svank svank commented Nov 26, 2024

PR summary

Last change, hopefully. Makes sure the slightly-offset edge values are used all around. Also tries to make it a bit more readable.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.04%. Comparing base (7818d2b) to head (d1bc4cb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files          56       56           
  Lines        3735     3735           
=======================================
  Hits         3251     3251           
  Misses        484      484           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes jmbhughes self-requested a review November 27, 2024 01:11
@jmbhughes jmbhughes merged commit 51171a0 into main Nov 27, 2024
7 of 8 checks passed
@jmbhughes jmbhughes deleted the one-more-bounding-box-fix branch November 27, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants