Be a little more accurate/safe with bounding boxes #327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
I remembered last night that Astropy has pixel centers at integer coordinates, so the image actually starts at -0.5, not 0, and so when we find a bounding box for mosaic reprojection (and also in the celestial intermediary code), the points we position along the edges of the input image should be along (x,y) = -0.5.
This PR puts them at -1, just for good measure. (The other side was already at
shape[0]
orshape[1]
, so it was already just a smidge past the actual edge which is atshape[0] - 0.5
.)I don't know why I'd originally set the points at (x,y) = 1 instead of (x,y) = 0. I'd count that as a bug, though it apparently wasn't affecting the test case I did yesterday.
Test plan
This just makes the bounding box bigger, so it shouldn't affect anything.