Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --definition to get to print definition #416

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Add --definition to get to print definition #416

merged 3 commits into from
Nov 5, 2024
+46 −1

Conversation

seanyeh
Copy link
Contributor

@seanyeh seanyeh commented Nov 5, 2024 •
edited
Loading

Fixes #415

Adds a --definition flag to the get command. we already have a --value command to only output the value, so I figured the --definition flag makes sense. open to other suggestions though

Testing

❯ go run ./cmd/esc env get temp2/abc/importer --definition --value json
Error: `--value` and `--definition` flags cannot be used together
exit status 1

❯ go run ./cmd/esc env get temp2/abc/importer --definition
imports:
  - abc/envvars
...

@komalali
Copy link
Member

komalali commented Nov 5, 2024

The --definition flag makes sense to me!

@seanyeh seanyeh marked this pull request as ready for review November 5, 2024 21:16
@seanyeh seanyeh merged commit 8a29190 into main Nov 5, 2024
6 checks passed
@seanyeh seanyeh deleted the syeh/get-raw branch November 5, 2024 21:28
@pulumi-bot
Copy link

This PR has been shipped in release v0.11.1.

@pulumi-bot pulumi-bot mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@komalali komalali komalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add command to print out raw definition
3 participants
@seanyeh @komalali @pulumi-bot