Update download links and blog post for Pulsar v1.119.0 #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blog content by confused-Techie, with copy-editing suggestions from Daeraxa and technical clarification from savetheclocktower. "Notice" section by confused-Techie, with an edit for clarification by me (DeeDeeG), plus feedback from savetheclocktower. Co-authored-by: confused_techie <[email protected]> Co-authored-by: Daeraxa <[email protected]> Co-authored-by: Andrew Dupont <[email protected]>
Daeraxa
reviewed
Jul 18, 2024
Comment on lines
25
to
34
| --- | ||
|
|
||
| ## **NOTICE** | ||
|
|
||
| Originally, the binaries from our normal "Pull Request" CI build (which produces unsigned binaries) were accidentally uploaded to this release, instead of the binaries from the special "tag push" CI build (which signs the macOS binaries). In order to provide you with signed macOS binaries, we are re-uploading the Intel macOS binaries and updating `SHA256SUMS.txt` to reflect this. As such the following binaries have been swapped out for the correct versions, with the checksum being updated as well for the following files: | ||
|
|
||
| - `Intel.Mac.Pulsar-1.119.0-mac.zip` | ||
| - `Intel.Mac.Pulsar-1.119.0.dmg` | ||
|
|
||
| --- |
There was a problem hiding this comment.
Suggested change
| --- | |
| ## **NOTICE** | |
| Originally, the binaries from our normal "Pull Request" CI build (which produces unsigned binaries) were accidentally uploaded to this release, instead of the binaries from the special "tag push" CI build (which signs the macOS binaries). In order to provide you with signed macOS binaries, we are re-uploading the Intel macOS binaries and updating `SHA256SUMS.txt` to reflect this. As such the following binaries have been swapped out for the correct versions, with the checksum being updated as well for the following files: | |
| - `Intel.Mac.Pulsar-1.119.0-mac.zip` | |
| - `Intel.Mac.Pulsar-1.119.0.dmg` | |
| --- | |
| --- | |
| ::: info Notice | |
| Originally, the binaries from our normal "Pull Request" CI build (which produces unsigned binaries) were accidentally uploaded to this release, instead of the binaries from the special "tag push" CI build (which signs the macOS binaries). | |
| In order to provide you with signed Intel macOS binaries, we are re-uploading them and updating `SHA256SUMS.txt` to reflect this. | |
| The following binaries have been swapped out for the correct versions and the checksums updated: | |
| - `Intel.Mac.Pulsar-1.119.0-mac.zip` | |
| - `Intel.Mac.Pulsar-1.119.0.dmg` | |
| ::: |
We should probably use an infobox here to draw attention to the notice. I've also attempted a little rewording and formatting to reduce some repetition and make it a bit easier to read.
There was a problem hiding this comment.
I committed it with a rephrase of the present-tense "we are re-uploading" stuff to past tense "we have re-uploaded", and so on. And removed one of the separator --- lines, since in my view the Notice infobox belongs with the main prose passage, IMO, not the bullet points of the "individual changes" section.
Co-authored-by: Daeraxa <[email protected]>
|
LGTM! Thanks for putting it all together |
Daeraxa
approved these changes
Jul 19, 2024
|
Merging, blog post should be live in a couple of minutes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the blog post and download link updates for Pulsar 1.119.0!
Blog content by confused-Techie, with copy-editing suggestions from Daeraxa and technical clarification from savetheclocktower.
"Notice" section by confused-Techie, with an edit for clarification by me (DeeDeeG), plus feedback from savetheclocktower.