Fix GetOrCreateSerializerMixin not working with pulp_domain #6078
Conversation
gerrod3
force-pushed
the
goc-mixin-domain
branch
from
cf42aea
to
2b3742d
Compare
| @@ -108,3 +115,27 @@ def test_ignored_fields_no_side_effects(): | |||
| initial_data = {"field1": 1, "csrfmiddlewaretoken": 2} | |||
| defined_fields = {"field1": 1} | |||
| validate_unknown_fields(initial_data, defined_fields) | |||
|
|
|||
|
|
|||
| class TestGetOrCreateSerializerMixin(TestCase): | |||
There was a problem hiding this comment.
Can you try if this creates valid pytest tests?
| class TestGetOrCreateSerializerMixin(TestCase): | |
| class TestGetOrCreateSerializerMixin(): |
There was a problem hiding this comment.
Looks like the setUp function may not be called with that name.
Also pytest really suggests to move to fixtures.
There was a problem hiding this comment.
Are there some docs or examples of unit tests with fixtures that hit the database? I was basing my tests off examples in pulp_container.
There was a problem hiding this comment.
I think this doc applies here.
https://pytest-django.readthedocs.io/en/latest/helpers.html#db
There was a problem hiding this comment.
Thanks, rewrote it the fixture way.
| @@ -108,3 +115,27 @@ def test_ignored_fields_no_side_effects(): | |||
| initial_data = {"field1": 1, "csrfmiddlewaretoken": 2} | |||
| defined_fields = {"field1": 1} | |||
| validate_unknown_fields(initial_data, defined_fields) | |||
|
|
|||
|
|
|||
| class TestGetOrCreateSerializerMixin(TestCase): | |||
There was a problem hiding this comment.
Looks like the setUp function may not be called with that name.
Also pytest really suggests to move to fixtures.
gerrod3
force-pushed
the
goc-mixin-domain
branch
from
2b3742d
to
c91e1e1
Compare
gerrod3
force-pushed
the
goc-mixin-domain
branch
from
c91e1e1
to
56d8674
Compare
|
If we're backporting this, it would be nice to have an issue filed |
Can this PR be the issue? Don't feel that we will get much benefit out of creating a duplicate issue that has no new information. |
pulp_domain is not processed in model's serializer since the value is auto-set as a context var on request time. This helper method would run into serializer errors if pulp_domain was specified as a natural key (which you need to do when supporting domains).