Update 'counts' response format tests #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the breaking change in the PR below, the resonse format has changed. No user facing features need updating, only the test assertions change by updating the fixture data. Required PR: pulp/pulpcore#2 You also need the following smash PR: Required PR: pulp/pulp-smash#1174 https://pulp.plan.io/issues/4283 re #4283
bmbouter
pushed a commit
to bmbouter/pulpcore
that referenced
this pull request
Mar 1, 2019
The performance issue causes us to introduce a new model named RepositoryVersionContentDetails. This is also a great opportunity to update the content_summary of the RepositoryVersion serializer to match the recent API changes. Most of this code was inspired from a patch from @dalley. This includes smash updates that are included in a separate PR. Required PR: pulp/pulp-smash#1174 This also fixes travis script lines that weren't updated due to pulp/pulp being moved to pulp/pulpcore. This PR needs that small fix to pass also. You also need the pulp_file PR below because it has tests which need updates to account for this backwards incompatible API change. Required PR: pulp/pulp_file#183 https://pulp.plan.io/issues/4283 closes pulp#4283
|
@bmbouter, I guess this PR requires the https://github.com/pulp/pulpcore/pull/2/files. |
|
I had pasted the wrong comment, it's correct now. Thanks @kersommoura |
|
Closing because we're going to port pulp-smash to provide the old interface and it can roll out it's breaking changes over time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the breaking change in the PR below, the resonse format has
changed. No user facing features need updating, only the test assertions
change by updating the fixture data.
Required PR: pulp/pulpcore#2
You also need the following smash PR:
Required PR: pulp/pulp-smash#1174
https://pulp.plan.io/issues/4283
re #4283