Mempool-Spatz #10
Merged
Mempool-Spatz #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mattsini1
commented
Feb 9, 2024
mattsini1
commented
- Add a target mempool in Bender to exclude the files not used in MemPool-Spatz configuration.
- add spatz_mempool_cc.sv used as core-complex level file in MemPool-Spatz configuration.
- add spatz_pkg.sv in hw/ip/spatz purely used for MemPool-Spatz configuration. Spatz Cluster will still refer to the generated package.
…roken at this point.
1. Various bug fixes in core complex level 2. Use MemPool reqrsp module instead of Spatz
Fix bugs and unify ports to MemPool.
Various bug fixes.
1. cleanup code. 2. recover bender targets commented out for MemPool-Spatz configuration.
bug fixes.
Fix a bug in not passing correct size to lsu in fpu_sequencer.
Clean up codes.
Fix trailing whitespaces and tabs.
1. Add a configuration file `mempool.hjson` to generate the `spatz_pkg.sv` 2. Add trace of stall signals of Spatz in `spatz_mempool_cc.sv`
1. Fix a bug that in MemPool the memory response may come out-of-order, mixing ACK from store requests and loaded data together. A `write` field is added in the data response channel in MemPool to identify the catalogue of the reponse signal. 2. Add a `ifdef` in vfu because VCS always tries to elaborate an non-reachable if-statement in MemPool, which `MAXEW == EW_64` and pops error message.
1. Fix a bug in decoding `VFMV_F_S` command. 2. Remove the performance tracer for Spatz in `spatz_mempool_cc.sv` because of the inaccuarcy in current version.
mp-17
reviewed
Feb 9, 2024
There was a problem hiding this comment.
LGTM. Thank you @DiyouS and @mattsini1 for the contribution!
Before merging: has anyone already tried this (from GitHub) with Mempool?
mp-17
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.