Skip to content

Commit

Permalink
[MXU] elaboration error in xilinx - fix attempt
Browse files Browse the repository at this point in the history
  • Loading branch information
Navaneeth-KunhiPurayil committed Dec 2, 2024
1 parent 85c60d5 commit ab29633
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions hw/ip/spatz/src/spatz_mxu.sv
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,12 @@ module spatz_mxu
// and we got a valid result

Check warning on line 250 in hw/ip/spatz/src/spatz_mxu.sv

View workflow job for this annotation

GitHub Actions / verible-verilog-lint

[verible-verilog-lint] hw/ip/spatz/src/spatz_mxu.sv#L250

Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]"  location:{path:"hw/ip/spatz/src/spatz_mxu.sv"  range:{start:{line:250  column:1}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}  suggestions:{range:{start:{line:250  column:1}  end:{line:252}}  text:"\n\n"}
// Start writes to VRF once we have send the last operands to the VFU
mx_to_write_vrf_d = mx_to_write_vrf_q ? 1'b1 : (vl_i >= last_word_i) & word_commited_o;

Check warning on line 252 in hw/ip/spatz/src/spatz_mxu.sv

View workflow job for this annotation

GitHub Actions / verible-verilog-lint

[verible-verilog-lint] hw/ip/spatz/src/spatz_mxu.sv#L252

Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]
Raw output
message:"Remove trailing spaces. [Style: trailing-spaces] [no-trailing-spaces]"  location:{path:"hw/ip/spatz/src/spatz_mxu.sv"  range:{start:{line:252  column:1}}}  severity:WARNING  source:{name:"verible-verilog-lint"  url:"https://github.com/chipsalliance/verible"}
if (~mx_to_write_vrf_q) begin
mx_to_write_vrf_d = (vl_i >= last_word_i) & word_commited_o;
end
// mx_to_write_vrf_d = mx_to_write_vrf_q ? 1'b1 : (vl_i >= last_word_i) & word_commited_o;

if (mx_to_write_vrf_d) begin
// Start writing to VRF once we have the part_acc pointing to 0
automatic logic write_en = (write_cnt_q == 0) ? (part_acc == 0) : 1'b1;
Expand All @@ -265,7 +270,12 @@ module spatz_mxu

// If the result from FPU is not to be written to the VRF, then store it in the accumulators
for (int accreg=0; accreg < NrACCBanks; accreg++) begin
accu_result_valid_d[accreg] = accu_result_valid_q[accreg] ? 1'b1 : ~mx_write_enable_d & waddr_onehot[accreg];
if (accu_result_valid_q[accreg]) begin
accu_result_valid_d[accreg] = 1'b1;
end else begin
accu_result_valid_d[accreg] = ~mx_write_enable_d & waddr_onehot[accreg];
end
// accu_result_valid_d[accreg] = accu_result_valid_q[accreg] ? 1'b1 : ~mx_write_enable_d & waddr_onehot[accreg];
end

if (enable_mx_i) begin
Expand Down

0 comments on commit ab29633

Please sign in to comment.