ipc: Handle failing RTL simulations #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug diagnosis
If the
SnitchSiminstance is waiting on aread()from the pipe to the simulation, and the RTL simulation terminates prematurely (e.g. due to a fatal assertion failure), theSnitchSiminstance would block on theread()and any verification script based on it would not terminate.Fix
When the simulation subprocess is spawned, a separate thread is created to monitor it. If the simulation terminates prematurely, the monitor will notice and send a
SIGINTsignal to interrupt theread(). The signal is handled by the main thread which will stop the simulation monitor, communicate the cause of the failure and gracefully terminate the verification script.