Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hw: Fix repeated load-stores in FPSS on WAW stall #92

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

colluca
Copy link
Collaborator

@colluca colluca commented Feb 14, 2024

Sometimes, when the floating-point subsystem is stalled on a load/store, it may issue it multiple times.

Since the lsu_qvalid and lsu_qready signals ignore dst_ready, it may occur, when dst_ready is 0, that we have a handshake on the LSU request interface (lsu_qvalid && lsu_qready), without the same handshake being propagated to the accelerator request interface, as acc_req_ready_q depends on dst_ready. Therefore, lsu_qvalid, which depends on acc_req_valid_q, will remain asserted, and repeated issues may occur.

This PR fixes this issue by only asserting lsu_qvalid when dst_ready is high.

@paulsc96 paulsc96 merged commit 4a1e067 into main Feb 14, 2024
27 checks passed
@paulsc96 paulsc96 deleted the fix/repeated-ldst branch February 14, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants