Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snrt_global_barrier requires additional snrt_cluster_hw_barrier #82

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

rogerbarton
Copy link
Collaborator

An additional snrt_cluster_hw_barrier is required before the DM cores synchronize.

Currently, the DM cores do not know if the other compute cores have arrived at the barrier. For example if a compute core in cluster 0 is late arriving at the barrier, other clusters will not wait for this core.

Copy link
Contributor

@fischeti fischeti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. Thanks!

@colluca colluca merged commit 62fb295 into main Jan 15, 2024
25 checks passed
@colluca colluca deleted the rbarton/global-barrier branch January 15, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants