Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spike-dasm: Add Snitch ISA aware riscv-isa-sim as submodule #32

Merged
merged 6 commits into from
Feb 21, 2024

Conversation

GiannaP
Copy link
Contributor

@GiannaP GiannaP commented Jul 28, 2023

Add Snitch ISA aware riscv-isa-sim version as submodule. Only used for spike-dasm to make the generated traces more readable.

In the old snitch repository it was flattened (without vendor) from the repository of @huettern. The branch was ported to the pulp-platform repository.

@GiannaP GiannaP marked this pull request as ready for review July 31, 2023 13:39
@colluca
Copy link
Collaborator

colluca commented Jul 31, 2023

We should adapt the Dockerfile to install spike-dasm also there.

If all we need from the repo is the spike-dasm executable, perhaps I wouldn't even submodule it, but tell users to clone the riscv-isa-sim repo separately and install it there. And maybe, since the manual installation is needed only when working outside the Docker container, we could have it installed system-wide on IIS machines so users don't even have to go through these additional installation steps.

docs/ug/getting_started.md Outdated Show resolved Hide resolved
@colluca colluca mentioned this pull request Aug 24, 2023
@paulsc96 paulsc96 added the limbo Stuck in discussion limbo label Sep 15, 2023
@paulsc96
Copy link
Collaborator

paulsc96 commented Sep 15, 2023

Behold my new idea: the limbo label 🥲 It labels PRs with long-term unresolved discussions. No, jokes aside, please look into this or redraft this PR.

@paulsc96 paulsc96 removed the limbo Stuck in discussion limbo label Sep 28, 2023
@colluca colluca marked this pull request as draft September 28, 2023 17:09
@colluca
Copy link
Collaborator

colluca commented Sep 29, 2023

I added the spike-dasm installation to the Docker container.

Last thing missing is a proper flow for installation on IIS machines. Specifically:

  • settle on a set of reproducible instructions (e.g. with a specific GCC version)
  • add the installation instructions to the CI (either on the snitch_cluster or riscv_isa_sim repo)
  • distribute a pre-built spike-dasm binary to IIS machines or provide instructions to install it (either on the snitch_cluster repo or point to riscv_isa_sim repo)

util/container/Dockerfile Outdated Show resolved Hide resolved
JosseVanDelm pushed a commit to JosseVanDelm/snitch_cluster that referenced this pull request Dec 11, 2023
* hw: Update SNAX control for 32-bit support

* hw: Update SNAX hwpe to reqrsp to support 32-bits

* hw: Take out unused parameter

* sw: Move uint64_t to uint32_t

* sw: Take out unnecessary debug code

* sw: Add new line to data.h
@colluca
Copy link
Collaborator

colluca commented Feb 20, 2024

I added releases to the riscv-isa-sim repo for both IIS machines and the Ubuntu-based Docker container.

Next steps involve:

  • Install spike-dasm on the Docker container from the official release
  • Install spike-dasm on the Gitlab CI and add installation instructions to the getting started guide

@colluca colluca force-pushed the spike-dasm branch 4 times, most recently from c8e2b8e to 3a70688 Compare February 21, 2024 12:37
@colluca colluca marked this pull request as ready for review February 21, 2024 13:25
@colluca colluca merged commit 6e72f08 into main Feb 21, 2024
25 of 27 checks passed
@colluca colluca deleted the spike-dasm branch February 21, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants