Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hw: Improve debug parameterization, fix debug CSR RW #27

Merged
merged 3 commits into from
Sep 28, 2023
Merged

hw: Improve debug parameterization, fix debug CSR RW #27

merged 3 commits into from
Sep 28, 2023

Conversation

paulsc96
Copy link
Collaborator

@paulsc96 paulsc96 commented Jul 13, 2023 •
edited
Loading

This includes the contributions from #7 and further gates debug features inside the Snitch core with parameters, controlled by the existing debug_enable configuration key:

  • It adds software RW to the dcsr, dpc, and dscratch0 registers.
  • It disables the instantiation of any debug registers, and thus logic through constant propagation, when debug_enable is 0.

@paulsc96 paulsc96 requested a review from colluca as a code owner July 13, 2023 16:14
@paulsc96 paulsc96 changed the title Add read write support for dcsr, dpc, and dscratch0 CSRs hw: Add RW support for dcsr, dpc, and dscratch0 CSRs Jul 13, 2023
@paulsc96 paulsc96 marked this pull request as draft September 15, 2023 14:45
@paulsc96 paulsc96 changed the title hw: Add RW support for dcsr, dpc, and dscratch0 CSRs hw: Improve debug parameterization, enable debug CSR RW Sep 27, 2023
@paulsc96 paulsc96 changed the title hw: Improve debug parameterization, enable debug CSR RW hw: Improve debug parameterization, fix debug CSR RW Sep 27, 2023
@paulsc96 paulsc96 marked this pull request as ready for review September 27, 2023 21:51
@colluca
Copy link
Collaborator

colluca commented Sep 28, 2023 •
edited
Loading

Should we perhaps add an assertion which raises an error or a warning if we get a irq_i.debug when DebugSupport is 0?

Otherwise LGTM :)

@paulsc96 paulsc96 merged commit 4174fa7 into main Sep 28, 2023
25 checks passed
@paulsc96 paulsc96 deleted the debug/fix branch September 28, 2023 12:23
@paulsc96 paulsc96 mentioned this pull request Sep 28, 2023
Closed
JosseVanDelm pushed a commit to JosseVanDelm/snitch_cluster that referenced this pull request Dec 11, 2023
@rgantonio @JosseVanDelm
Add GEMM sw tests (pulp-platform#27)
1396a4a 
* sw: Add GEMM sw test

* sw: Lint codes

* lint: Add license

* sw: Add base test without the GEMM engine

* sw: Add engine and base test to apps Makefile

* sw: Add GEMM tests to test list

* lint: Exclude GEMM tests from license check

* sw: Add new lines at the end of each file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colluca colluca colluca approved these changes

@lucabertaccini lucabertaccini Awaiting requested review from lucabertaccini lucabertaccini is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulsc96 @colluca