Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: Replace spike-dasm in favor of llvm-mc #187

Merged
merged 4 commits into from
Aug 29, 2024
Merged

util: Replace spike-dasm in favor of llvm-mc #187

merged 4 commits into from
Aug 29, 2024

Conversation

fischeti
Copy link
Contributor

For trace generation we currently use spike-dasm to dissassemble single instructions from core log files. The problem with spike-dasm is that is an external executable, that needs to be maintained by us. For instance, new instructions need to be added manually to spike-dasm for decoding.

The better alternative is llvm-mc which is a CLI tool that is compiled alongside LLVM. This means all our custom ISA extensions supported by the LLVM toolchain are also automatically supported by llvm-mc and don't have to be added manually to the dissasembler as before.

@fischeti fischeti marked this pull request as ready for review August 27, 2024 13:00
Copy link
Collaborator

@colluca colluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one minor comment :)

util/trace/gen_trace.py Outdated Show resolved Hide resolved
@colluca colluca merged commit e0fc33a into main Aug 29, 2024
27 checks passed
@colluca colluca deleted the new-dasm branch August 29, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants